On Thu, 10 Feb 2022 22:20:48 GMT, Roger Riggs <[email protected]> wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed LocalizedPrinterParser.toString() to reflect requestedTemplate
>
> src/java.base/share/classes/sun/util/locale/provider/LocaleResources.java
> line 690:
>
>> 688: private String resolveInputSkeleton(String type) {
>> 689: var regionToSkeletonMap = inputSkeletons.get(type);
>> 690: return regionToSkeletonMap.getOrDefault(locale.getLanguage() +
>> "-" + locale.getCountry(),
>
> This structure computes all the defaults even if the value isn't needed
> (because the value has to be passed to the `getOrDefault` method. Perhaps
> performance isn't an issue.
Indeed, yes. I thought this was simple enough, and as you said, not
performance-critical.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7340
