> Upon review of [8261407](https://bugs.openjdk.java.net/browse/JDK-8261407), > by design, duplicate initialization of ReflectionFactory should be safe as it > performs side-effect-free property read actions, and the suggesting of making > the `initted` field volatile cannot prevent concurrent initialization either; > however, having `initted == true` published without the other fields' values > is a possibility, which this patch addresses. > > This simulates what's done in `CallSite`'s constructor for > `ConstantCallSite`. Please feel free to point out the problems with this > patch, as I am relatively inexperienced in this field of fences and there are > relatively less available documents. (Thanks to > https://shipilev.net/blog/2014/on-the-fence-with-dependencies/)
liach has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revision: - Merge branch 'master' into 8261407-reflectionfactory - Whitespace issues - Refine docs, pull members out of the config record - The fast path should always come first. good lesson learned! restore config field comments - Try making the config a record and see if it works - Make config a pojo, move loading code into config class - use peter's model of separate data object - Merge branch 'master' into 8261407-reflectionfactory - Include the stable annotation - Merge branch 'master' into 8261407-reflectionfactory - ... and 3 more: https://git.openjdk.java.net/jdk/compare/4727f4af...e97ea278 ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/6889/files - new: https://git.openjdk.java.net/jdk/pull/6889/files/548946a7..e97ea278 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=6889&range=08 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=6889&range=07-08 Stats: 18722 lines in 492 files changed: 13328 ins; 2982 del; 2412 mod Patch: https://git.openjdk.java.net/jdk/pull/6889.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6889/head:pull/6889 PR: https://git.openjdk.java.net/jdk/pull/6889
