On Mon, 21 Feb 2022 19:55:14 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
> Please review this PR that enables > [Zc:strictStrings](https://docs.microsoft.com/en-us/cpp/build/reference/zc-strictstrings-disable-string-literal-type-conversion?view=msvc-170) > compiler flag, which makes assigning a string literal to a non-const pointer > a compile-time error. > > This type of assignment is [disallowed by C++ standard since > C++11](https://en.cppreference.com/w/cpp/language/string_literal). Writing to > a string literal through a non-const pointer [produces a run-time > error](https://docs.microsoft.com/en-us/cpp/cpp/string-and-character-literals-cpp?view=msvc-170#microsoft-specific-1). > > The included code changes are trivial; I added `const` keyword to variable > and parameter declarations where needed, and added explicit casts to > non-const pointers where adding `const` was not feasible. > > I verified that the build passes both with and without `--enable-debug`, both > with VS2017 and VS2019. Hi Daniel, Hotspot changes look fine. Some of the casts in other code look odd to me, but I'll leave that for the security-libs folk to comment on. Thanks, David ------------- Marked as reviewed by dholmes (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7565
