On Fri, 25 Feb 2022 01:13:41 GMT, Yasser Bazzi <d...@openjdk.java.net> wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i >> decided to use the >> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html >> interface to create the default method `asRandom()` that wraps around the >> newer algorithms to be used on classes that do not accept the new interface. >> >> Some things to note as proposed by the bug report, the protected method >> next(int bits) is not overrided and setSeed() method if left blank up to >> discussion on what to do with it. >> >> Small test done on >> https://gist.github.com/YShow/da678561419cda8e32fccf3a27a649d4 > > Yasser Bazzi has updated the pull request incrementally with two additional > commits since the last revision: > > - change wrong indentation > - change indentation test/jdk/java/util/Random/RandomTest.java line 420: > 418: */ > 419: public void testShufflingList() { > 420: final ArrayList listTest = new ArrayList<Integer>(); Suggestion: final var listTest = new ArrayList<Integer>(); Using `ArrayList<Integer>` is fine too, but right now this is a raw type. ------------- PR: https://git.openjdk.java.net/jdk/pull/7001