On Tue, 8 Mar 2022 03:49:43 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Ian Graves has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains two commits: >> >> - merging master >> - Catching erronious setting of matcher.hitEnd > > test/jdk/java/util/regex/RegExTest.java line 4568: > >> 4566: >> 4567: var matcher1 = Pattern.compile(pat1).matcher(testInput); >> 4568: var matcher2 = Pattern.compile(pat2).matcher(testInput); > > Hello Ian, > The JBS issue notes that the bug is only noticed when the `Pattern.CANON_EQ` > is used. The javadoc of this `CANON_EQ` states that this isn't enabled by > default. Do you think this test should also include matchers which use > Pattern(s) with this `CANON_EQ` explicitly enabled? Oh wow yes. Thanks for this catch. I was rewriting the tests to fit this mold and left the flags out. Added them back in. Thanks again! ------------- PR: https://git.openjdk.java.net/jdk/pull/7466
