On Wed, 16 Feb 2022 21:19:04 GMT, Olga Mikhaltsova <omikhaltc...@openjdk.org>
wrote:
> This fix made equal processing of strings such as ""C:\\Program
> Files\\Git\\"" before and after JDK-8250568.
>
> For example, it's needed to execute the following command on Windows:
> `C:\Windows\SysWOW64\WScript.exe "MyVB.vbs" "C:\Program Files\Git" "Test"`
> it's equal to:
> `new ProcessBuilder("C:\\Windows\\SysWOW64\\WScript.exe", "MyVB.vbs",
> ""C:\\Program Files\\Git\\"", "Test").start();`
>
> While processing, the 3rd argument ""C:\\Program Files\\Git\\"" treated as
> unquoted due to the condition added in JDK-8250568.
>
> private static String unQuote(String str) {
> ..
> if (str.endsWith("\\"")) {
> return str; // not properly quoted, treat as unquoted
> }
> ..
> }
>
>
> that leads to the additional surrounding by quotes in
> ProcessImpl::createCommandLine(..) because needsEscaping(..) returns true due
> to the space inside the string argument.
> As a result the native function CreateProcessW
> (src/java.base/windows/native/libjava/ProcessImpl_md.c) gets the incorrectly
> quoted argument:
>
> pcmd = C:\Windows\SysWOW64\WScript.exe MyVB.vbs ""C:\Program Files\Git"" Test
> (jdk.lang.Process.allowAmbiguousCommands = true)
> pcmd = "C:\Windows\SysWOW64\WScript.exe" MyVB.vbs ""C:\Program Files\Git\\""
> Test
> (jdk.lang.Process.allowAmbiguousCommands = false)
>
>
> Obviously, a string ending with `"\\""` must not be started with `"""` to
> treat as unquoted overwise it’s should be treated as properly quoted.
This pull request has been closed without being integrated.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7504
