On Fri, 11 Mar 2022 10:42:02 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org> wrote:
>> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Leave public for the time being > > src/java.base/share/classes/java/lang/runtime/Carrier.java line 57: > >> 55: * @since 19 >> 56: */ >> 57: /*non-public*/ > > What does this non-public comment mean? We might switch to package private for String Template preview. I forgot that the test can't locate the class if I make it package private, > src/java.base/share/classes/java/lang/runtime/Carrier.java line 146: > >> 144: * @return constructor with arguments recasted and reordered >> 145: */ >> 146: private static MethodHandle reshapeConstructor(CarrierShape >> carrierShape, > > I like how reshape constructors and components is now shared across both > implementations Refactoring is just another tool for the lazy. ;-) ------------- PR: https://git.openjdk.java.net/jdk/pull/7744
