On Tue, 22 Mar 2022 10:09:40 GMT, Claes Redestad <redes...@openjdk.org> wrote:
>> Xin Liu has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains six additional commits >> since the last revision: >> >> - Merge branch 'master' into JDK-8282429 >> - split StringBuilder.toString() performance test out of StringBuilders.java >> - Change growOnly to maybeLatin. >> >> This patch also copys over the attribute from the other >> AbstractStringBuilder. >> Add a unit test to cover methods which cause maybeLatin1 becomes true. >> - make sure String(StringBuffer) is still synchronized. >> - Add a microbenchmark. >> - 8282429: StringBuilder/StringBuffer.toString() skip compressing for >> UTF16 strings > > Thanks for refactoring the micro to avoid the redundant run overheads, and > checking that the we're size neutral on all configurations. > > I have added a few minor comments inline that you can choose to address or > ignore. > > Good work! hi, @cl4es @djelinski , Could you take another look at the latest revision? thanks, --lx ------------- PR: https://git.openjdk.java.net/jdk/pull/7671
