On Tue, 29 Mar 2022 13:58:56 GMT, ExE Boss <d...@openjdk.java.net> wrote:

>> Jim Laskey has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Add condy static methods
>
> src/java.base/share/classes/java/lang/runtime/Carrier.java line 335:
> 
>> 333:             CarrierArray(int primitiveCount, int objectCount) {
>> 334:                 this.primitives =
>> 335:                     primitiveCount != 0 ? new long[(primitiveCount + 1) 
>> / 2] : null;
> 
> It might be better to use an unsigned shift here:
> Suggestion:
> 
>                     primitiveCount != 0 ? new long[(primitiveCount + 1) >>> 
> 1] : null;

doesn't the compiler (either javac or hotspot) automatically do that?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7744

Reply via email to