On Wed, 6 Apr 2022 01:23:15 GMT, Joe Wang <jo...@openjdk.org> wrote: >> Clean up the usages of isAssignableFrom in a few xpath and jdk/internal >> classes where the checks were really about equality or whether they were the >> exact class types. It was why they worked nonetheless even though some of >> them were backwards. >> >> Test: existing tests passed. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > replace with instanceof
Looks good to me. This would have been a premiere example for switch pattern match, but hey. ------------- Marked as reviewed by naoto (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8116