On Wed, 6 Apr 2022 17:39:48 GMT, John R Rose <jr...@openjdk.org> wrote:
>> Paul Sandoz has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Doc and test updates. > > test/jdk/java/lang/AbstractCompressExpandTest.java line 145: > >> 143: >> 144: int i = 0; >> 145: for (int len = 0; len < 32; len++) { > > Lengths should be `len = 1; len <= 32; len++`, generating fewer redundant > zero-length masks and a full-length -1 mask. The pos should be `pos = 0; pos > <= 32 - len; pos++`, generating fully left-justified masks of the form > `-1<<pos`. > > Also, you should generate a zero-mask, just once. I think initializing `int > i = 1` will do that trick. > > (Same comment in two places.) Done. ------------- PR: https://git.openjdk.java.net/jdk/pull/8115