On Thu, 28 Apr 2022 14:44:05 GMT, Erik Gahlin <egah...@openjdk.org> wrote:
>> Alan Bateman has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refresh 7965cc6b168e567ac2596f2fbc3b00a7d99b7e1e
>
> src/hotspot/share/jfr/leakprofiler/sampling/objectSampler.cpp line 168:
>
>> 166: assert(!tl->is_excluded(), "invariant");
>> 167: if (virtual_thread) {
>> 168: // TODO: blob cache for virtual threads
>
> Fix this now or after integration?
Well spotted. It is an optimization and can happen after integration. I will
create an enhancement for tracking; thank you.
> src/hotspot/share/jfr/metadata/metadata.xml line 121:
>
>> 119: thread="true" stackTrace="true">
>> 120: <Field type="Thread" name="carrierThread" label="Carrier Thread"
>> description="Thread enlisted as a carrier" />
>> 121: <Field type="Class" name="contClass" label="Continuation class"
>> description="Class of the continuation" />
>
> "Continuation class" = >" Continuation Class"
> numFrames = frames
> numRefs = references
> "Number of interpreted frames" => "Interpreted Frames"
> "Number of references" => "References"
> "Stack size in bytes" => "Stack Size" contentType"bytes"
Will fix.
> src/hotspot/share/jfr/metadata/metadata.xml line 130:
>
>> 128: thread="true" stackTrace="true">
>> 129: <Field type="Thread" name="carrierThread" label="Carrier Thread"
>> description="Thread enlisted as a carrier" />
>> 130: <Field type="Class" name="contClass" label="Continuation class"
>> description="Class of the continuation" />
>
> contClass => continuationClass
> "Continuation class" => "Continuation Class"
> "Class of the continuation" Remove (not needed)
> "Number of interpreted frames" => "Interpreted Frames"
> numFrames => frames
> "Number of references" => "References"
> numRefs => references
> "Stack size in bytes" => "Stack Size" contentType="bytes"
Will fix.
> src/hotspot/share/jfr/metadata/metadata.xml line 138:
>
>> 136: <Event name="ContinuationFreezeYoung" experimental="true"
>> category="Java Virtual Machine" label="Continuation Freeze Young"
>> thread="true" stackTrace="false" startTime="false">
>> 137: <Field type="ulong" name="id" label="Continuation ID" />
>> 138: <Field type="uint" name="size" label="Size" />
>
> "Allocated new" => "Allocated New"
Will fix, thanks.
> src/jdk.jfr/share/classes/jdk/jfr/events/VirtualThreadEndEvent.java line 35:
>
>> 33:
>> 34: @Category({"Java Runtime"})
>> 35: @Label("Virtual thread end")
>
> "Virtual thread end" => "Virtual Thread End"
> Remove description.
Will fix.
> src/jdk.jfr/share/classes/jdk/jfr/events/VirtualThreadPinnedEvent.java line
> 35:
>
>> 33:
>> 34: @Category({"Java Runtime"})
>> 35: @Label("Virtual thread pinned")
>
> "Virtual thread pinned" => "Virtual Thread Pinned"
> Remove description
Will fix.
> src/jdk.jfr/share/classes/jdk/jfr/events/VirtualThreadStartEvent.java line 35:
>
>> 33:
>> 34: @Category({"Java Runtime"})
>> 35: @Label("Virtual thread start")
>
> "virtual thread start" => "Virtual Thread Start"
> Remove description
Will fix, thanks.
> src/jdk.jfr/share/classes/jdk/jfr/events/VirtualThreadSubmitFailedEvent.java
> line 35:
>
>> 33:
>> 34: @Category({"Java Runtime"})
>> 35: @Label("Virtual thread submit task failed")
>
> The label is a bit a long, would "Virtual Thread Submit Failed" work?
It works. Thanks.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8166
