On Fri, 29 Apr 2022 08:15:32 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org> 
wrote:

>> This PR contains the API and implementation changes for JEP-424 [1]. A more 
>> detailed description of such changes, to avoid repetitions during the review 
>> process, is included as a separate comment.
>> 
>> [1] - https://openjdk.java.net/jeps/424
>
> Maurizio Cimadamore has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Tweak Addressable javadoc

src/java.base/share/classes/jdk/internal/misc/X-ScopedMemoryAccess.java.template
 line 101:

> 99:     }
> 100: 
> 101:     public final static class ScopedAccessError extends Error {

This should probably use the canonical modifier order as specified in 
[JDK‑8276348] ([GH‑6213]):
Suggestion:

    public static final class ScopedAccessError extends Error {


[JDK‑8276348]: https://bugs.openjdk.java.net/browse/JDK-8276348 "[JDK‑8276348] 
Use blessed modifier order in java.base"
[GH‑6213]: https://github.com/openjdk/jdk/pull/6213

-------------

PR: https://git.openjdk.java.net/jdk/pull/7888

Reply via email to