On Wed, 11 May 2022 22:03:38 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> It would not make sense to set the disabled warning in the configure script, > no. The current code looks perfectly fine. Disabled warnings per module are > set in the makefiles. OK, that you for your feedback regarding the makefile changes vs. configure script. > > If you feel strongly that this needs to be documented more than in the JBS > issue and this PR review, updating the zlib ChangeLog file is probably the > way to go. I have no strong opinion on that. But from the build system PoV, > the current code is fine as it is to be committed. OK, I am probably overthinking the need to document this ------------- PR: https://git.openjdk.java.net/jdk/pull/8651
