On Tue, 17 May 2022 13:55:43 GMT, Yasumasa Suenaga <ysuen...@openjdk.org> wrote:
>> GCC 12 reports as following: > > Yasumasa Suenaga has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains three additional > commits since the last revision: > > - Use assert() to check jargv > - Merge remote-tracking branch 'upstream/master' into JDK-8286694 > - 8286694: Incorrect argument processing in java launcher Looks fine to me. Thanks. Sorry I see what you mean, it is just an `assert(cond)` not `assert(cond, message)`, but that is fine. src/java.base/share/native/libjli/java.c line 1631: > 1629: const char *arg = jargv[i]; > 1630: if (arg[0] == '-' && arg[1] == 'J') { > 1631: assert(arg[2] != '\0' && "Invalid JAVA_ARGS or > EXTRA_JAVA_ARGS defined by build"); Interesting trick. ------------- Marked as reviewed by dholmes (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8694