On Wed, 18 May 2022 23:28:22 GMT, Vladimir Ivanov <vliva...@openjdk.org> wrote:
>> Its more of a chicken-egg problem here, for masked reverse operation, >> Reverse IR node is followed by a Blend Node, thus in such a case doing an >> eager Identity transform in Reverse::Identity will not work, also deferring >> this to blend may also not work since it could be a non-masked reverse >> operation, we could have handled it as a special case in >> inline_vector_nary_operation, but handling such special case in final graph >> reshaping looked more appropriate. >> >> https://github.com/openjdk/panama-vector/pull/182#discussion_r845678080 > > Do you mean it's important to apply the transformation at the right node > (pick the right node as the root) and it is hard to make a decision during > GVN? Yes, that what I meant. ------------- PR: https://git.openjdk.java.net/jdk/pull/8425
