On Tue, 31 May 2022 17:07:06 GMT, Raffaello Giulietti <d...@openjdk.java.net> wrote:
>> Hello, >> >> here's a PR for a patch submitted on March 2020 >> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was >> a thing. >> >> The patch has been edited to adhere to OpenJDK code conventions about >> multi-line (block) comments. Nothing in the code proper has changed, except >> for the addition of redundant but clarifying parentheses in some expressions. >> >> >> Greetings >> Raffaello > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > 4511638: Double.toString(double) sometimes produces incorrect results src/java.base/share/classes/jdk/internal/math/FloatToDecimal.java line 40: > 38: final public class FloatToDecimal { > 39: /* > 40: * For full details about this code see the following references: Same comment about `<cite/>`. src/java.base/share/classes/jdk/internal/math/FloatToDecimal.java line 97: > 95: private static final int MASK_28 = (1 << 28) - 1; > 96: > 97: private static final int NON_SPECIAL = 0; As these are shared with `DoubleToDecimal` would these constants be better moved to a common location, e.g., `MathUtils` whether converted to an `enum` or not? src/java.base/share/classes/jdk/internal/math/FloatToDecimal.java line 118: > 116: private int index; > 117: > 118: private FloatToDecimal() { Same comment about preventing instantiation. ------------- PR: https://git.openjdk.java.net/jdk/pull/3402
