On Fri, 3 Jun 2022 11:16:29 GMT, Claes Redestad <redes...@openjdk.org> wrote:
> - Add explicit run configurations to java.lang.invoke micros, aiming to > reduce runtime while maintaining a decently high confidence that there's > enough warmup to produce good enough data. > > - Remove several trivial baseline micros, mainly those that only return a > static object: It's reasonable to have baseline microbenchmarks when the > baseline op is complex and you're mostly interested in checking the overhead > of doing the same thing via some MH API, but blackhole operations are now > shortcutting very quickly and timings doesn't differ from one type of object > to another, so we don't need a multitude of such baseline tests. > > Estimated runtime of `make test TEST=micro:java.lang.micro` (excluding build) > drops from just above 28 to just above 3 hours. test/micro/org/openjdk/bench/java/lang/invoke/LookupAcquire.java line 59: > 57: @Setup > 58: public void setup() { > 59: cached = MethodHandles.lookup(); Since the benchmark using the cached object is removed, should this field be removed as well? ------------- PR: https://git.openjdk.java.net/jdk/pull/9012