On Fri, 10 Jun 2022 18:01:24 GMT, Alan Bateman <al...@openjdk.org> wrote:

>> Thiago Henrique Hüpner has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Fix copyright year
>
> test/jdk/tools/jar/modularJar/Basic.java line 44:
> 
>> 42: 
>> 43: import jdk.internal.module.ModuleReferenceImpl;
>> 44: import jdk.internal.module.ModuleResolution;
> 
> At some point we need to put in test infrastructure to avoid this and a few 
> other tests from depending on JDK internals.

Do you think it is better to parse the output of `javap` instead of using the 
internals to detect if it worked?

-------------

PR: https://git.openjdk.org/jdk/pull/9049

Reply via email to