On Mon, 13 Jun 2022 07:24:52 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
>> We still handle at a number of places ancient historic _MSC_VER versions of
>> Visual Studio releases e.g. pre VS2013 (VS2013 has _MSC_VER 1800).
>> This should be cleaned up, as long as it is not 3rd party code that we don't
>> want to adjust.
>>
>> Currently still supported ("valid") VS version are 2017+, see
>> https://github.com/openjdk/jdk/blob/master/make/autoconf/toolchain_microsoft.m4
>> .
>> VALID_VS_VERSIONS="2019 2017 2022"
>> Even with adjusted toolchain m4 files, something older than VS2013 (also
>> probably older than VS2015) would not be able to build jdk anymore.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last revision:
>
> use round directly
src/hotspot/share/adlc/main.cpp line 491:
> 489: }
> 490:
> 491: // VS2005 has its own definition, identical to this one.
Let's adjust comment too. No need to mention VS2005.
-------------
PR: https://git.openjdk.org/jdk/pull/9105
