On Mon, 10 Oct 2022 04:35:12 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Julian Waters has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 16 additional >> commits since the last revision: >> >> - Merge branch 'openjdk:master' into patch-4 >> - Merge branch 'openjdk:master' into patch-4 >> - Use - instead of : as a separator >> - Merge branch 'openjdk:master' into patch-4 >> - Make DLL_ERROR4 look a little better without changing what it means >> - Revert changes to JLI_ReportErrorMessageSys >> - Update java_md.c >> - Update java_md.h >> - Merge branch 'openjdk:master' into patch-4 >> - Merge branch 'openjdk:master' into patch-4 >> - ... and 6 more: https://git.openjdk.org/jdk/compare/ad28ef9e...c3113cac > > src/java.base/windows/native/libjli/java_md.h line 48: > >> 46: */ >> 47: >> 48: void reportWithLastWindowsError(const char* message, ...); > > Why does this need to be exported in the header file? Are you expecting other > code to call this? I left that in there since it would possibly be a useful utility to have for other JLI code that might need to work with Windows errors in the future ------------- PR: https://git.openjdk.org/jdk/pull/9749
