Re: RFR: 8295239: Refactor java/util/Formatter/Basic script into a Java native test launcher [v11]

[Lance Andersen]

On Thu, 20 Oct 2022 19:56:04 GMT, Justin Lu <d...@openjdk.org> wrote:

>> Issue: Formatter unit tests are launched via basic.sh
>> 
>> Fix: Replace basic.sh with a Java test launcher
>> 
>> Note: Java.internal.math was included in the original configuration of 
>> Basic, but I removed it as it was not used within the Basic unit tests 
>> 
>> 
>> Original output on success
>> <img 
>> src="https://user-images.githubusercontent.com/67398801/195936541-bc90db50-8d03-47be-9c4f-95176b19a6a7.png";
>>  width="350" height="350">
>> 
>> 
>> New output on success
>> <img 
>> src="https://user-images.githubusercontent.com/67398801/195936558-f85f4d48-dae2-4c38-aa50-46ef47db3d89.png";
>>  width="350" height="450">
>
> Justin Lu has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Spacing conventions

Marked as reviewed by lancea (Reviewer).

test/jdk/java/util/Formatter/Basic.java line 94:

> 92:             var tests_message = "%d tests: %d 
> failure(s)%n".formatted(fail + pass, fail);
> 93:             var trace_message = "Traceback of the first error located";
> 94:             String message = "%s %s".formatted(tests_message, 
> trace_message);

could use "var" as the previous statements ;-)

-------------

PR: https://git.openjdk.org/jdk/pull/10715