> ClassFile API provides two sets of instructions implementations (bound and > unbound). > Unbound implementation of `IncrementInstruction::constant` returns invalid > value. > This bug discovered a hole in the ClassFile API test coverage. > > This patch provides very simple fix of `IncrementInstruction` > and more complex fix of the test framework to cover all unbound instruction > with automated tests. > > The test framework fix includes correction of hash calculation of > instructions in `ClassRecord` and > two-pass transformation in `RebuildingTransformation`. Second pass has been > added to discover bugs in unbound-to-unbound instruction conversions. > > Please review. > > Thanks, > Adam
Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: Update test/jdk/jdk/classfile/helpers/RebuildingTransformation.java Co-authored-by: Andrey Turbanov <turban...@gmail.com> ------------- Changes: - all: https://git.openjdk.org/jdk/pull/17770/files - new: https://git.openjdk.org/jdk/pull/17770/files/92d5af38..8586d628 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=17770&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17770&range=00-01 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/17770.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17770/head:pull/17770 PR: https://git.openjdk.org/jdk/pull/17770
