On Mon, 2 Jun 2025 11:54:10 GMT, Alice Pellegrini <d...@openjdk.org> wrote:

> The implemented solution modifies the `OutputBuffer` implementation instead 
> of the `OutputAnalyzer` implementation.
> This is because the **OutputBuffer implementation which handles processes** 
> (LazyOutputBuffer) starts a thread in its constructor, so we would need to 
> add a strange additional constructor parameter to the 
> `OutputBuffer.of(Process, Charset)` static method, while the printing through 
> to stdout (and stderr) only makes sense for LazyOutputBuffer.
> 
> I believe changing the config option from `outputanalyzer.verbose` to `output 
> buffer.verbose` would make it cleaner, and avoid referencing the 
> OutputAnalyzer in the OutputBuffer implementation.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk/pull/25587

Reply via email to