On Tue, 10 Mar 2026 06:37:29 GMT, Jatin Bhateja <[email protected]> wrote:
>> Hi all, >> >> This patch optimizes SIMD kernels making heavy use of broadcasted inputs >> through following reassociating ideal transformations. >> >> >> VectorOperation (VectorBroadcast INP1, VectorBroadcast INP2) => >> VectorBroadcast (ScalarOpration INP1, INP2) >> >> VectorOperation (VectorBroadcast INP1) (VectorOperation (VectorBroadcast >> INP2) INP3) => >> VectorOperation INP3 (VectorOperation >> (VectorBroadcast INP1) (VectorBroadcast INP2)) >> >> >> The idea is to push broadcasts across the vector operation and replace the >> vector with an equivalent, cheaper scalar variant. Currently, patch handles >> most common vector operations. >> >> Following are the performance number of benchmark included with this patch >> on latest generation x86 targets:- >> >> **AMD Turin (2.1GHz)** >> <img width="1122" height="355" alt="image" >> src="https://github.com/user-attachments/assets/3f5087bf-0e14-4c56-b0c2-3d23253bad54" >> /> >> >> **Intel Granite Rapids (2.1GHz)** >> <img width="1105" height="325" alt="image" >> src="https://github.com/user-attachments/assets/c8481f86-4db2-4c4e-bd65-51542c59fe63" >> /> >> >> >> >> Kindly review and share your feedback. >> >> Best Regards, >> Jatin > > Jatin Bhateja has updated the pull request incrementally with one additional > commit since the last revision: > > Review comments resolution test/hotspot/jtreg/compiler/vectorapi/TestVectorBroadcastReassociationTransforms.java line 44: > 42: * => VectorOp(broadcast(ScalarOp(a, b)), array) > 43: */ > 44: public class TestVectorBroadcastReassociationTransforms { This isn’t a strong request from my side, but it might be better to rename the test to `TestVectorReassociations` or `VectorReassociationTest`, and the benchmark to `VectorReassociateBenchmark`, to keep them consistent with the existing tests and benchmarks. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25617#discussion_r2921824428
