On Mon, 26 Jan 2026 18:22:30 GMT, Eirik Bjørsnøs <[email protected]> wrote:

> Please consider this PR which bumps the size of attempted allocations with 1m 
> such that the tests are less brittle to  JDK-internal native memory use.
> 
> These tests currently run with `XX:MallocLimit=other:100m:oom`, but also try 
> to allocate `100 * 1024 * 1024` bytes.
> 
> With current JDK-internal native memory use, these allocation fail with OOM. 
> When the JDK itself uses less memory, these tests start failing because 
> allocation succeeds.
> 
> I think we should simply try to allocate one more megabyte than the 
> configured limit, which should cause the allocation to fail regardless of 
> internal JVM native memory use.

Thank you for taking this change.
LGTM

-------------

Marked as reviewed by azafari (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/29429#pullrequestreview-3967725333

Reply via email to