On Mon, 18 May 2026 09:04:53 GMT, Alan Bateman <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 19 additional >> commits since the last revision: >> >> - Alan's review - update the class level doc >> - merge latest from master branch >> - merge latest from master branch >> - merge latest from master branch >> - minor adjustments >> - Lance's review >> - merge latest from master branch >> - introduce test to verify read() throws IOException when invoked on closed >> stream >> - specify existing behaviour of throwing IOException when stream is already >> closed >> - merge latest from master branch >> - ... and 9 more: https://git.openjdk.org/jdk/compare/d2fbf13c...40a57962 > > src/java.base/share/classes/java/util/zip/GZIPInputStream.java line 55: > >> 53: * ahead in the underlying stream while completing a member or >> determining whether another >> 54: * member follows. Consequently, an unspecified number of bytes beyond a >> member’s trailer >> 55: * may be consumed. If the bytes read ahead do not constitute a valid >> header for a > > "do not constitute a valid header". Do you mean the IDentification bytes or > what validation is really done here? These header bytes not containing the magic header, or the stream ending midway before the entire header bytes are read, or the header bytes containing unexpected data (for example unsupported compression method), all constitute as invalid header. In some other review comments you have suggested updating this class level javadoc to a greater degree. I'll reword this line when updating this section to remove the mention of "valid". ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30925#discussion_r3298315981
