On Wed, Sep 14, 2016 at 12:36 PM, Donald Stufft <don...@stufft.io> wrote: > Code Reviews! - This provides a more traditional code review feature set for > Pull Requests. When making a comment on a github Pull request you now have > the option between “Add a single comment” (what previously existed”) and > “Start a review”. This also allows people to submit all their comments at > once as Just comments, or with an Approval or Disapproval of the PR as it > exists. Approval/disapproval shows up like a CI status check and repositories > can optionally have branches flagged as requiring review (which requires at > least one approval, and no disapprovals).
The whole one-email-per-comment thing has been my main objection to doing code review through GitHub. So I'm glad that's been resolved. There are plenty of other features I'd like (i.e. that ReviewBoard gives you), but none of them are game changers. Hey, I'm just glad I don't have to avoid doing code reviews on GitHub now! :) -eric _______________________________________________ core-workflow mailing list core-workflow@python.org https://mail.python.org/mailman/listinfo/core-workflow This list is governed by the PSF Code of Conduct: https://www.python.org/psf/codeofconduct
