I'm totally fine with the idea of having a core-specific, short message of "There's a review; the trigger phrase is '...'".
On Wed, 22 Nov 2017 at 09:33 Mariatta Wijaya <mariatta.wij...@gmail.com> wrote: > Gotcha :) > > Well the useful part of that message is it contains the phrase: "I have > made the requested changes; please review again". > I think it's convenient to be able to copy paste it to trigger the next > state change. > > Maybe for core devs, we can shorten the message to at least include the > trigger phrase. > > Mariatta Wijaya > > On Tue, Nov 21, 2017 at 11:52 PM, Nick Coghlan <ncogh...@gmail.com> wrote: > >> On 22 November 2017 at 13:24, Mariatta Wijaya <mariatta.wij...@gmail.com> >> wrote: >> >>> How would folks feel about the idea of tweaking the bot to check if >>>> the PR submitter was a core dev, and skip the process explanation >>>> messages in that case? >>> >>> >>> From what I understand, what you're asking is that the state change >>> label still gets applied, (for example the 'awaiting changes' label) but >>> you don't want bedevere-bot to leave the comment "A Python core >>> developer has requested some changes ..." if the PR author is a core >>> developer? >>> >> >> Aye, that's the specific message that makes me roll my eyes and think >> "Yes, Bedevere, thank you, I already know how that bit of the process >> works". >> >> I think the other message: "please review the changes made to this pull >>> request" should remain. >>> >> >> Good point, that's a useful prompt regardless of who wrote the original >> PR. >> >> Cheers, >> Nick. >> >> -- >> Nick Coghlan | ncogh...@gmail.com | Brisbane, Australia >> > >
_______________________________________________ core-workflow mailing list -- core-workflow@python.org To unsubscribe send an email to core-workflow-le...@python.org https://mail.python.org/mm3/mailman3/lists/core-workflow.python.org/ This list is governed by the PSF Code of Conduct: https://www.python.org/psf/codeofconduct
