On Mon, 10 Sep 2018 at 11:50 Mariatta Wijaya <mariatta.wij...@gmail.com> wrote:
> I prefer keeping the labeling as is, so core devs PR get "awaiting merge" > label upon creation. > > If a core dev actually want someone else to review it, I suggest using the > "request review" feature, and select another core dev to review the PR. > Do the people wanting other core devs to review typically have someone they want to review, or just anyone to do a review? > At that time, bedevere should apply the "awaiting core review" label. At > least, that would be my expectation. If it doesn't do that, then that's the > change we should implement, instead of the "no label by default". > I don't think it does. -Brett > > Mariatta > > ᐧ > > On Thu, Sep 6, 2018 at 12:47 PM Berker Peksağ <berker.pek...@gmail.com> > wrote: > >> On Thu, Sep 6, 2018 at 10:37 PM Brett Cannon <br...@python.org> wrote: >> > On Wed, 5 Sep 2018 at 13:37 Zachary Ware <zachary.ware+py...@gmail.com> >> wrote: >> >> What about no label at all on core dev PRs by default, but if one gets >> >> added the standard flow is followed? >> > >> > >> > I would be fine with that. What do others think? >> >> +1 >> >> If no one beats me to it by the end of this month, I can submit a PR >> that implements Zachary's suggestion.. >> >> --Berker >> _______________________________________________ >> core-workflow mailing list -- core-workflow@python.org >> To unsubscribe send an email to core-workflow-le...@python.org >> https://mail.python.org/mm3/mailman3/lists/core-workflow.python.org/ >> This list is governed by the PSF Code of Conduct: >> https://www.python.org/psf/codeofconduct >> > _______________________________________________ > core-workflow mailing list -- core-workflow@python.org > To unsubscribe send an email to core-workflow-le...@python.org > https://mail.python.org/mm3/mailman3/lists/core-workflow.python.org/ > This list is governed by the PSF Code of Conduct: > https://www.python.org/psf/codeofconduct >
_______________________________________________ core-workflow mailing list -- core-workflow@python.org To unsubscribe send an email to core-workflow-le...@python.org https://mail.python.org/mm3/mailman3/lists/core-workflow.python.org/ This list is governed by the PSF Code of Conduct: https://www.python.org/psf/codeofconduct
