On Jan 25, 2008 5:57 PM, Carl-Daniel Hailfinger > > + olen = file.reallen; > > + printk(BIOS_DEBUG, "buf ilen %d olen%ld\n", file.len, olen); > > > > Hm. Why is olen an unsigned long when reallen is u32?
Fixed. I got rid of olen, this was its only use. > > + printk(BIOS_DEBUG, "biosint: gs 0x%lx fs 0x%lx ds 0x%lx es 0x%lx\n", > > gsfs >> 16, gsfs & 0xffff, dses >> 16, dses & 0xffff); > > > > If cs, ds, es, fs are all 16bit, then dses and gsfs should be explicitly > 32bit and not long. That would fix compile warnings as well. I > understand that biosint is x86emu code, though. We need to clean up the other parts of the code, make things u32 and u16, I am going to hold off until we do that. R562 Thanks ron -- coreboot mailing list [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
