On Fri, 2008-02-22 at 23:52 +0100, Ronald Hoogenboom wrote:
> Then the fan is properly controlled. BUT this stuff is far too
> mainboard specific (as opposed to superio specific) to be in this
> file. It should be in a file in the mainboard/gigabyte/m57sli
> directory (probably even V2.0 specific). But I wouldn't know how to
> link it in so it gets called in the ec_init routine. Do you have some
> suggestions?
> Maybe there is a way to put it in the Config.lb file?
>
I've found a way: provide the ec_init routine in a source file in the
mainboard/gigabyte/m57sli directory. I've also added a Config variable
'HAVE_FANCTL' to notify to superio.c to get the ec_init externally.
This patch adds automatic fan control for the CPU fan on the m57sli
board.
Signed-off-by: Ronald Hoogenboom <[EMAIL PROTECTED]>
Index: src/superio/ite/it8716f/superio.c
===================================================================
--- src/superio/ite/it8716f/superio.c (revision 3114)
+++ src/superio/ite/it8716f/superio.c (working copy)
@@ -62,6 +62,9 @@
return inb(port_base + 1);
}
+#ifdef HAVE_FANCTL
+extern void init_ec(uint16_t base);
+#else
static void init_ec(uint16_t base)
{
uint8_t value;
@@ -77,6 +80,7 @@
printk_debug("FAN_CTL: reg = 0x%04x, writing value = 0x%02x\r\n",
base + 0x14, value | 0x87);
}
+#endif
static void it8716f_init(device_t dev)
{
Index: src/mainboard/gigabyte/m57sli/Config.lb
===================================================================
--- src/mainboard/gigabyte/m57sli/Config.lb (revision 3114)
+++ src/mainboard/gigabyte/m57sli/Config.lb (working copy)
@@ -206,6 +206,10 @@
end
end
+if HAVE_FANCTL
+ object fanctl.o
+end
+
##
## Setup RAM
##
Index: src/mainboard/gigabyte/m57sli/Options.lb
===================================================================
--- src/mainboard/gigabyte/m57sli/Options.lb (revision 3114)
+++ src/mainboard/gigabyte/m57sli/Options.lb (working copy)
@@ -115,6 +116,7 @@
uses CONFIG_USE_PRINTK_IN_CAR
+uses HAVE_FANCTL
###
### Build options
###
@@ -140,6 +142,11 @@
default CONFIG_LB_MEM_TOPK=2048
##
+## Set-up automatic fan control
+##
+default HAVE_FANCTL=1
+
+##
## Build code for the fallback boot
##
default HAVE_FALLBACK_BOOT=1
Index: src/mainboard/gigabyte/m57sli/fanctl.c
===================================================================
--- src/mainboard/gigabyte/m57sli/fanctl.c (revision 0)
+++ src/mainboard/gigabyte/m57sli/fanctl.c (revision 0)
@@ -0,0 +1,57 @@
+#include <arch/io.h>
+
+static void write_index(uint16_t port_base, uint8_t reg, uint8_t value)
+{
+ outb(reg, port_base);
+ outb(value, port_base + 1);
+}
+
+static const struct {
+ uint8_t index, value;
+} sequence[]= {
+ /* Set FAN_CTL control register (0x14) polarity to high, and
+ activate fans 1, 2 and 3. */
+ { 0x14, 0x87},
+ /* set the correct sensor types 1,2 thermistor; 3 diode */
+ { 0x51, 0x1c},
+ /* set the 'zero' voltage for diode type sensor */
+ { 0x5c, 0x80},
+// { 0x56, 0xe5},
+// { 0x57, 0xe5},
+ { 0x59, 0xe5},
+ { 0x5c, 0x00},
+ /* fan1 (controlled by temp3) control parameters */
+ /* fan off limit */
+ { 0x60, 0xff},
+ /* fan start limit */
+ { 0x61, 0x14},
+ /* ???? */
+// { 0x62, 0x00},
+ /* start PWM */
+ { 0x63, 0x27},
+ /* smooth and slope PWM */
+ { 0x64, 0x90},
+ /* direct-down and interval */
+ { 0x65, 0x03},
+ /* fan1 auto controlled by temp3 */
+ { 0x15, 0x82},
+ /* fan2 soft controlled, max speed */
+ { 0x16, 0x7f},
+ /* fan3 soft controlled, 75% speed */
+ { 0x17, 0x60},
+ /* all fans enable, fan1 ctl smart */
+ { 0x13, 0x71}
+};
+
+#define ARRAYSIZE(x) sizeof x/sizeof *x
+
+/*
+ * Called from superio.c
+ */
+void init_ec(uint16_t base)
+{
+ int i;
+ for (i=0; i<ARRAYSIZE(sequence); i++) {
+ write_index(base, sequence[i].index, sequence[i].value);
+ }
+}
Index: src/config/Options.lb
===================================================================
--- src/config/Options.lb (revision 3114)
+++ src/config/Options.lb (working copy)
@@ -861,6 +866,11 @@
# Misc device options
###############################################
+define HAVE_FANCTL
+ default 0
+ export used
+ comment "Include board specific FAN control initialization"
+end
define CONFIG_TSC_X86RDTSC_CALIBRATE_WITH_TIMER2
default 0
export used
--
coreboot mailing list
[email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
