On Tue, Sep 30, 2008 at 5:02 PM, <[EMAIL PROTECTED]> wrote:
> Author: uwe
> Date: 2008-09-30 17:02:40 +0200 (Tue, 30 Sep 2008)
> New Revision: 3622
[...]
> - sysconf.hc_possible_num = sizeof(pci1234x) / sizeof(pci1234x[0]);
> - sysconf.hc_possible_num = sizeof(pci1234x) / sizeof(pci1234x[0]);
> + /* FIXME: Is this really needed twice? */
> + sysconf.hc_possible_num = ARRAY_SIZE(pci1234x);
> + sysconf.hc_possible_num = ARRAY_SIZE(pci1234x);
> for (i = 0; i < sysconf.hc_possible_num; i++) {
> sysconf.pci1234[i] = pci1234x[i];
> sysconf.hcdn[i] = hcdnx[i];
Looks like a cut'n'paste error or a mismerge.
Or is there something magical behind that variable that really
needs to be written 2 times in a row ? If this is the case I would
add a big fat comment about that fact...
--
Vincent Legoll
--
coreboot mailing list: coreboot@coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot
