Author: hailfinger
Date: 2008-11-26 03:16:37 +0100 (Wed, 26 Nov 2008)
New Revision: 1058

Modified:
   coreboot-v3/arch/x86/intel/core2/stage0.S
   coreboot-v3/arch/x86/stage1.c
Log:
Experimental backout of the critical code parts in r1057 as requested
by Stefan.
The only changes left from r1057 are:
- Added comments
- Two initial pushes of 0x00000000 (32 bits each) to the stack as safety

Signed-off-by: Carl-Daniel Hailfinger <[EMAIL PROTECTED]>
Acked-by: Carl-Daniel Hailfinger <[EMAIL PROTECTED]>


Modified: coreboot-v3/arch/x86/intel/core2/stage0.S
===================================================================
--- coreboot-v3/arch/x86/intel/core2/stage0.S   2008-11-25 23:39:31 UTC (rev 
1057)
+++ coreboot-v3/arch/x86/intel/core2/stage0.S   2008-11-26 02:16:37 UTC (rev 
1058)
@@ -176,7 +176,10 @@
        /* First parameter: bist */
        pushl   %eax
 
+#if 0
+       /* this will be interpreted as failed bist */
        port80_post(0x23)
+#endif
 
        call    stage1_phase1
        /* We will not go back. */

Modified: coreboot-v3/arch/x86/stage1.c
===================================================================
--- coreboot-v3/arch/x86/stage1.c       2008-11-25 23:39:31 UTC (rev 1057)
+++ coreboot-v3/arch/x86/stage1.c       2008-11-26 02:16:37 UTC (rev 1058)
@@ -187,7 +187,7 @@
  * that we are restarting after some sort of reconfiguration. Note that we 
could use it on geode but 
  * do not at present. 
  */
-void __attribute__((stdcall,regparm(0))) stage1_phase1(u32 bist, u32 
init_detected)
+void __attribute__((stdcall)) stage1_phase1(u32 bist, u32 init_detected)
 {
        struct global_vars globvars;
        int ret;


--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to