On Tue, Nov 25, 2008 at 9:18 PM, Bao, Zheng <[EMAIL PROTECTED]> wrote:
> Hi,
> Attachment are the patches for Chipset AMD RS690, AMD SB600 and mainboard
> DBM690T. The following ACPI features are supported.
> 1. S1, S5 sleep and wake up (by power button or PS/2 keyboard/mouse).
> 2. AMD powernow-k8 driver.
> 3. Thermal configuration based on ADT7461.
> 4. IDE timing settings.
> 5. HPET timer.
> 6. Interrupt routing based on ACPI table.
I would request one change. When there is a HALT type error, such as this:
printk_info("rs690_enable: CAN NOT FIND SB bridge, HALT!\n");
it would be best to do this instead:
die("rs690_enable: CAN NOT FIND SB bridge, HALT!\n");
So, for example:
printk_info("rs690_enable: CAN NOT FIND SB bridge, HALT!\n");
for (;;) ;
becomes instead:
die("rs690_enable: CAN NOT FIND SB bridge, HALT!\n");
/*NOTREACHED*/
The rest of this patch looks fine.
If you can change the "HALT" printk_info to die, then:
Acked-by: Ronald G. Minnich <[EMAIL PROTECTED]>
ron
--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
