Uwe Hermann wrote:
> > There's a pciconf.h with PCI conf constants - lets actually use it
> >
> > PCI_CONF_REG_{INDEX,DATA} constants instead of 0xCF8 and 0xCFF everywhere.
> > Not touching YABEL as I'm not sure it would want to include that header.
> >
> > Signed-off-by: Mart Raudsepp <[email protected]>
>
> Acked-by: Uwe Hermann <[email protected]>
Please don't commit this. I would rather see the 0xcf8 and cfc
defines removed. This is PCI code, these ports will never change
for PCI buses, and they are the first thing most learn about PCI
programming.
Defines add indirection = complexity = error sources. I'm with
Stefan, we should use them carefully.
//Peter
--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
