Kevin O'Connor wrote: > On Sun, Feb 22, 2009 at 10:14:56PM -0800, Yinghai Lu wrote: >> please check >> >> [PATCH] x86: check physptr with max_low_pfn on 32bit > > Thanks for looking at this issue. > > Unfortunately, the kernel still does not work with the applied patch. > Neither 32bit nor 64bit kernels boot. (Note, I applied the patch to > Linus' git, and I had to replace mpf->physptr with mpf->mpf_physptr.) > > The error messages from before and after patching appear to be the > same. > >
please add this patch too [PATCH] x86: ioremap mptable Impact: fix boot with mptable above max_low_mapped try to use early_ioremap it. Signed-off-by: Yinghai Lu <[email protected]> --- arch/x86/kernel/mpparse.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) Index: linux-2.6/arch/x86/kernel/mpparse.c =================================================================== --- linux-2.6.orig/arch/x86/kernel/mpparse.c +++ linux-2.6/arch/x86/kernel/mpparse.c @@ -611,12 +611,20 @@ static void __init __get_smp_config(unsi construct_default_ISA_mptable(mpf->feature1); } else if (mpf->physptr) { + struct mpc_table *mpc; + unsigned int length; + mpc = early_ioremap(mpf->physptr, PAGE_SIZE); + length = mpc->length; + apic_printk(APIC_VERBOSE, " mpc: %x-%x\n", mpf->physptr, + mpf->physptr + length); + early_iounmap(mpc, PAGE_SIZE); + mpc = early_ioremap(mpf->physptr, length); /* * Read the physical hardware table. Anything here will * override the defaults. */ - if (!smp_read_mpc(phys_to_virt(mpf->physptr), early)) { + if (!smp_read_mpc(mpc, early)) { #ifdef CONFIG_X86_LOCAL_APIC smp_found_config = 0; #endif @@ -624,9 +632,12 @@ static void __init __get_smp_config(unsi "BIOS bug, MP table errors detected!...\n"); printk(KERN_ERR "... disabling SMP support. " "(tell your hw vendor)\n"); + early_iounmap(mpc, length); return; } + early_iounmap(mpc, length); + if (early) return; #ifdef CONFIG_X86_IO_APIC -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
