On Tue, Mar 24, 2009 at 12:32 PM, Myles Watson <[email protected]> wrote:
> > > > -----Original Message----- > > From: [email protected] [mailto: > [email protected]] > > On Behalf Of Peter Stuge > > Sent: Tuesday, March 24, 2009 10:06 AM > > To: [email protected] > > Subject: Re: [coreboot] [PATCH] fix object/driver confusion ofall > > northbridge code > > > > Stefan Reinauer wrote: > > > Every object file with a struct pci_driver ... __pci_driver needs to > > > be marked as "driver" instead of "object" in order to get the init > > > code actually executed. > > > > > > This patch fixes up all northbridges that did not do this before. > > > > > > Signed-off-by: Stefan Reinauer <[email protected]> > > > > Acked-by: Peter Stuge <[email protected]> > > > > How come we have not noticed this before? Do these NB drivers not do > > anything critical? > > It is hard to believe that the amdk8 northbridge code never got executed. > Is this only true if it's not contained in a "chip", or if you don't > specify > its position in the device tree? I'm grasping at straws, but I think it had something to do with multiple drivers in northbridge.c, if it's marked as a driver only the first driver would get run, or it might have been something to do with the special pci domain and cpu bus drivers. Then again, I could be entirely wrong, it's been a while. -Corey
-- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
