> > Let's not create a whole file for one obj. Can we just put that in > > socket_AM2/Makefile.inc like the intel sockets do? > > > > obj-y += ../microcode/microcode.o > > The reason to create a whole file for one object is that, over time, > kif we get more than one object, nobody has to change their makefiles > -- we add to microcode/Makefile.inc. > > I think the subdir usage and extra Makefile.inc are fine, if we're > going to have the directory. OK. > At same time, I'm not overly concerned either way. I have to go out > rest of the day, the AM2 patch is almost there, Myles, can you and > Cristi wrap it up? I've made so many Kconfig mistakes I'm not sure I'm the right person to Ack & commit. But I don't have any objections to the patch.
Myles -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot