Am 25.03.2010 08:37, schrieb Bao, Zheng: > 1. Remove warnings and multiple blank lines. > 2. Mahogany uses GPIO9 to detect 80-pin IDE cable. > > Signed-off-by: Zheng Bao <zheng....@amd.com>
> Index: src/mainboard/amd/mahogany_fam10/mainboard.c > =================================================================== > --- src/mainboard/amd/mahogany_fam10/mainboard.c (revision 5287) > +++ src/mainboard/amd/mahogany_fam10/mainboard.c (working copy) > @@ -79,27 +84,29 @@ > sm_dev = dev_find_slot(0, PCI_DEVFN(0x14, 0)); > > byte = pci_read_config8(sm_dev, 0xA9); > - byte |= (1 << 4); /* Set Gpio8 as input */ > + byte |= (1 << 5); /* Set Gpio8 as input */ That should also be Gpio9, right? I can't test it, but it looks plausible. Assuming you tested it, and with that comment fixed, it's Acked-by: Patrick Georgi <patrick.geo...@coresystems.de> Patrick -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot