On 4/16/10 2:43 PM, Myles Watson wrote: >> Modified: trunk/util/vgabios/include/console/console.h >> ========================================================================== >> ==== >> --- trunk/util/vgabios/include/console/console.h Fri Apr 16 03:45:44 >> 2010 (r5450) >> +++ trunk/util/vgabios/include/console/console.h Fri Apr 16 13:45:16 >> 2010 (r5451) >> @@ -1,3 +1,4 @@ >> #ifndef _CONSOLE_CONSOLE_H >> #define _CONSOLE_CONSOLE_H >> +#define CONFIG_X86EMU_DEBUG 1 >> > If this is a config variable it should be set in Kconfig. If it isn't, it > should probably have a different name.
It's a utility completely independent of coreboot (well, supposed to be), just sharing some code. So I think it should not depend on the coreboot Kconfig. But I didn't want to add a separate Kconfig build system either, so I just hard coded the one variable... -- coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br. Tel.: +49 761 7668825 • Fax: +49 761 7664613 Email: i...@coresystems.de • http://www.coresystems.de/ Registergericht: Amtsgericht Freiburg • HRB 7656 Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866 -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot