[coreboot] [commit] r5461 - trunk/src/northbridge/amd/lx

[repository service]

Author: stepan
Date: Tue Apr 20 17:49:59 2010
New Revision: 5461
URL: https://tracker.coreboot.org/trac/coreboot/changeset/5461

Log:
cosmetics.
Signed-off-by: Stefan Reinauer <ste...@coresystems.de>
Acked-by: Stefan Reinauer <ste...@coresystems.de>

Modified:
   trunk/src/northbridge/amd/lx/pll_reset.c
   trunk/src/northbridge/amd/lx/raminit.c

Modified: trunk/src/northbridge/amd/lx/pll_reset.c
==============================================================================
--- trunk/src/northbridge/amd/lx/pll_reset.c    Tue Apr 20 15:22:02 2010        
(r5460)
+++ trunk/src/northbridge/amd/lx/pll_reset.c    Tue Apr 20 17:49:59 2010        
(r5461)
@@ -24,17 +24,13 @@
 
        msrGlcpSysRstpll = rdmsr(GLCP_SYS_RSTPLL);
 
-       print_debug("_MSR GLCP_SYS_RSTPLL (");
-       print_debug_hex32(GLCP_SYS_RSTPLL);
-       print_debug(") value is: ");
-       print_debug_hex32(msrGlcpSysRstpll.hi);
-       print_debug(":");
-       print_debug_hex32(msrGlcpSysRstpll.lo);
-       print_debug("\n");
+       printk(BIOS_DEBUG, "MSR GLCP_SYS_RSTPLL (%08x) value is %08x:%08x\n",
+               GLCP_SYS_RSTPLL, msrGlcpSysRstpll.hi, msrGlcpSysRstpll.lo);
+
        post_code(POST_PLL_INIT);
 
        if (!(msrGlcpSysRstpll.lo & (1 << RSTPLL_LOWER_SWFLAGS_SHIFT))) {
-               print_debug("Configuring PLL\n");
+               printk(BIOS_DEBUG, "Configuring PLL.\n");
                if (manualconf) {
                        post_code(POST_PLL_MANUAL);
                        /* CPU and GLIU mult/div (GLMC_CLK = GLIU_CLK / 2)  */
@@ -62,13 +58,13 @@
                msrGlcpSysRstpll.lo |= RSTPPL_LOWER_CHIP_RESET_SET;
                wrmsr(GLCP_SYS_RSTPLL, msrGlcpSysRstpll);
 
-               /*      You should never get here..... The chip has reset. */
-               print_debug("CONFIGURING PLL FAILURE\n");
+               /* You should never get here..... The chip has reset. */
+               printk(BIOS_ERR, "CONFIGURING PLL FAILURE\n");
                post_code(POST_PLL_RESET_FAIL);
                __asm__ __volatile__("hlt\n");
 
        }
-       print_debug("Done pll_reset\n");
+       printk(BIOS_DEBUG, "PLL configured.\n");
        return;
 }
 

Modified: trunk/src/northbridge/amd/lx/raminit.c
==============================================================================
--- trunk/src/northbridge/amd/lx/raminit.c      Tue Apr 20 15:22:02 2010        
(r5460)
+++ trunk/src/northbridge/amd/lx/raminit.c      Tue Apr 20 17:49:59 2010        
(r5461)
@@ -29,10 +29,7 @@
 
 static void banner(const char *s)
 {
-       /* This is so ugly. */
-       print_debug("===========================");
-       print_debug(s);
-       print_debug("======================================\n");
+       printk(BIOS_DEBUG, " * %s\n", s);
 }
 
 static void hcf(void)
@@ -572,7 +569,7 @@
 {
        uint8_t spd_byte;
 
-       banner("sdram_set_spd_register\n");
+       banner("sdram_set_spd_register");
        post_code(POST_MEM_SETUP);      // post_70h
 
        spd_byte = spd_read_byte(DIMM0, SPD_MODULE_ATTRIBUTES);

-- 
coreboot mailing list: coreboot@coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot