Op zondag 9 mei 2010 00:00:22 schreef u:
> On 5/1/10 1:58 AM, Nils wrote:
> > Index: src/northbridge/amd/gx2/northbridgeinit.c
> > ===================================================================
> > --- src/northbridge/amd/gx2/northbridgeinit.c (revision 5520)
> > +++ src/northbridge/amd/gx2/northbridgeinit.c (working copy)
> > @@ -672,7 +672,7 @@
> > {
> > uint64_t shadowSettings = getShadow();
> > shadowSettings &= (uint64_t) 0xFFFF00000000FFFFULL; // Disable
read &
> > writes - shadowSettings |= (uint64_t) 0x00000000F0000000ULL; //
Enable
> > reads for F0000-FFFFF + shadowSettings |= (uint64_t)
> > 0x0000FFFFFFFF0000ULL; // Enable reads for C0000-FFFFF
> > setShadow(shadowSettings);
> > }
>
> What's this doing?
>
> Is it potentially dangerous for other systems?
>
Hi Stefan,
I specifically tested this again on my patched rev5470 (the last working
version here) and it is needed there.
Without it Seabios refuses to work and coreboot reboots.
I don`t know what it does on current trunk because it never gets til Seabios.
I don`t think it is dangrous to other systems because the GX2 tree is broken
for more than a year and probably never worked with Seabios.
It would be nice if you could commit it.
Thanks,Nils.
--
coreboot mailing list: coreboot@coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot
