On 5/14/10 11:42 PM, Uwe Hermann wrote: > On Wed, May 05, 2010 at 03:12:42PM +0200, repository service wrote: > >> Modified: trunk/src/mainboard/a-trend/atc-6220/devicetree.cb >> ============================================================================== >> --- trunk/src/mainboard/a-trend/atc-6220/devicetree.cb Wed May 5 >> 14:05:25 2010 (r5524) >> +++ trunk/src/mainboard/a-trend/atc-6220/devicetree.cb Wed May 5 >> 15:12:42 2010 (r5525) >> @@ -1,7 +1,7 @@ >> chip northbridge/intel/i440bx # Northbridge >> - device apic_cluster 0 on # APIC cluster >> + device lapic_cluster 0 on # APIC cluster >> chip cpu/intel/slot_1 # CPU >> - device apic 0 on end # APIC >> + device lapic 0 on end # APIC >> > Shouldn't the comments also read LAPIC cluster and LAPIC here? >
The comments? I think we should remove them. device lapic_cluster # LAPIC cluster has about the same value as i++; // Post increment i. ie. it does not help the reader in any way that is not written there without the comment. On the contrary, it makes changing the code more effort at no gain. Stefan -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
