9.9.2010 22:39, Myles Watson kirjoitti:
There are now three smaller patches attached:
Much nicer! Thanks.
(1) Changes specific to this board. Fairly small changes from AMD
Tilapia. Requires (2) to work.
From your mainboard's Kconfig:
+config DIMM_SUPPORT
+ hex
+ default 0x0004
+ depends on CPU_AMD_SOCKET_AM3
This really worries me. You shouldn't need to change the type of memory on
the Socket. I looked at your board online, and they suggest that your board
supports socket AM2, AM2+, and AM3. That seems like it breaks our model. I
thought AM2 was DDR2 and AM3 was DDR3.
Sorry to break your design, but that was what I had to do to get the RAM
working. I can confirm that I am using DDR2 memory and the CPU is this:
http://products.amd.com/en-na/DesktopCPUDetail.aspx?id=615
In general, the fewer changes the better!
I agree. The patches could be smaller and neater.
However, I cannot hold on to this board for arbitrarily long, since I
should put it to production use now that Coreboot is working. I will
see what I can do to reduce these patches further, if I just find a
suitable slot of time.
Best regards,
Juhana Helovuo
--
coreboot mailing list: coreboot@coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot
