* Peter Stuge <pe...@stuge.se> [101026 18:36]: > Patrick Georgi wrote: > > attached patch fixes boot on my bcm5785-based board with low loglevels. > > I guess without some serial text early on (which is slow), the devices > > aren't readily available, and so things go wrong and finally hang on the > > last write operation in the modified function. > > > > I opted against a timeout + error, as there's no useful alternative > > action to do on error. An error message to notify the developer that > > something is going wrong, to simplify debugging after so-and-so many > > iterations might still be useful - but what's the right number? :-) > > > > > > Signed-off-by: Patrick Georgi <patrick.geo...@coresystems.de> > > NAK-by: Peter Stuge <pe...@stuge.se> > > I think that having a timeout is pretty important, and if it times > out then call die. I'll ack that. Maybe give it a second or so?
Remember it can not print anything this early. -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot