On Sun, Nov 21, 2010 at 08:31:55PM +0000, Jonathan A. Kollasch wrote: > -#define CK804_CHIP_REV 3
Hm, why remove CK804_CHIP_REV? I have no idea if or how that's supposed to be used etc., though. Here's a quick grep: southbridge/nvidia/ck804/ck804_early_setup_car.c:#define CK804_CHIP_REV 3 southbridge/nvidia/ck804/ck804_early_setup.c:#define CK804_CHIP_REV 3 southbridge/nvidia/ck804/ck804_lpc.c:#define CK804_CHIP_REV 2 southbridge/nvidia/ck804/ck804_lpc.c:#if CK804_CHIP_REV==1 southbridge/nvidia/ck804/ck804_lpc.c:#if CK804_CHIP_REV == 1 Maybe we should keep the #define until we know more. The rest of the patch looks ok. Acked-by: Uwe Hermann <u...@hermann-uwe.de> Uwe. -- http://hermann-uwe.de | http://sigrok.org http://randomprojects.org | http://unmaintained-free-software.org -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
