Am 08.12.2010 07:20, schrieb Stefan Reinauer: > On 12/7/10 10:00 PM, Peter Stuge wrote: >> repository service wrote: >>> first round name simplification. drop the <component>_ prefix. >> Beautiful. >> >>> +++ trunk/src/mainboard/advantech/pcm-5820/romstage.c Wed Dec 8 >>> 06:42:47 2010 (r6149) >>> @@ -27,7 +27,7 @@ >>> #include "northbridge/amd/gx1/raminit.c" >>> #include "cpu/x86/bist.h" >>> #include "superio/winbond/w83977f/w83977f_early_serial.c" >> Maybe the early_* files should be renamed to romstage as well? >> >> >> //Peter >> > I like the idea... Will finish the northbridge and superios first, and > let someone else do the early->romstage deed :) Sounds good. Also, the bootblock.c files usually include another .c file for now (so we are able to use the same southbridge code with or without bootblock). Once a southbridge is entirely tinybootblocked, that could be inlined (and the early_rom stuff dropped).
Patrick -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
