Scott Duplichan wrote: > ]> A video option rom needs to be added to support the built-in uma > ]> graphics. > ] > ]Does the default filename match what was extracted from factory EFI? > > I do not know of a way to recover the original filename of the > extracted video BIOS. After booting the factory BIOS, I saved > physical memory range C0000-CFFFF to a file with a made up name.
Ahh! And that worked? It doesn't always. The original filename would be discovered by using bios_extract or another similar tool on the factory firmware image. That also doesn't work always, but it's worth a try. > > +++ src/mainboard/asrock/e350m1/dsdt.asl (working copy) > > @@ -23,7 +23,7 @@ > > "DSDT", /* Signature */ > > 0x02, /* DSDT Revision, needs to be 2 for 64bit */ > > "AMD ", /* OEMID */ > > - "PERSIMMO", /* TABLE ID */ > > + "E350M1 ", /* TABLE ID */ > > ]Also change AMD? > Thanks for pointing this out, I changed it. > In the revised patch, I also changed it in mptable.c Nice catch! > +++ src/mainboard/asrock/e350m1/mainboard.c (working copy) .. > @@ -110,6 +110,6 @@ > return 0; > } > struct chip_operations mainboard_ops = { > - CHIP_NAME("AMD PERSIMMON Mainboard") > - .enable_dev = persimmon_enable, > + CHIP_NAME(CONFIG_MAINBOARD_VENDOR " " CONFIG_MAINBOARD_PART_NUMBER " > Mainboard") > + .enable_dev = e350m1_enable, Some whitespace on the CHIP_NAME line seems off. After that and if you find something out about the VGA BIOS filename it's Acked-by: Peter Stuge <pe...@stuge.se> -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot