* Sven Schnelle <sv...@stackframe.org> [110419 21:47]:
> Signed-off-by: Sven Schnelle <sv...@stackframe.org>
  
>  static void ti_pci1x2y_init(struct device *dev)
>  {
> +
>       printk(BIOS_INFO, "Init of Texas Instruments PCI1x2x PCMCIA/CardBus 
> controller\n");
> +     struct southbridge_ti_pci1x2x_config *conf = dev->chip_info;

You should check if dev or conf is actually set before accessing it.
I believe if the device is not mentioned in devicetree.cb conf will be
NULL.

See some i82801gx drivers for an example.

Other than that:

Acked-by: Stefan Reinauer <stefan.reina...@coreboot.org>



-- 
coreboot mailing list: coreboot@coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to